Fix active window not working on the framebuffer #94
Conversation
Remove the inefficiently function twin_active_pixmap(). This function finds the currently and previously active window pixel map by traversing the list of pixel maps. This function will be called every time the screen needs to be updated. Set the active variable of the window only when the window's event TwinEventButtonDown is triggered to avoid redundant operations. Additionally, implement the function twin_window_active_paint() to only repaint the title bar instead of calling the function twin_window_draw() to indirectly call the function twin_window_frame to repaint the title bar of the window. Close sysprog21#92 Signed-off-by: Wei-Hsin Yeh <[email protected]>
src/window.c
Outdated
| @@ -156,6 +156,19 @@ void twin_window_set_name(twin_window_t *window, const char *name) | |||
| strcpy(window->name, name); | |||
| twin_window_draw(window); | |||
| } | |||
| static void twin_window_active_paint(twin_window_t *window) | |||
There was a problem hiding this comment.
Missing one empty line here.
|
Looks legitimate to me, but since I am not familiar with recent developments, I would like to see if others have different opinions. |
|
I confirmed that fbdev can run on a VM with Ubuntu 24.04 and a Pi 3B. Below is the output from the Pi 3B. test.mp4 |
|
The title bars of the active and inactive window don't display on the video. |
src/window.c
Outdated
| twin_fixed_t bw_2 = bw / 2; | ||
| if (window->active) { | ||
| twin_paint_path(window->pixmap, TWIN_ACTIVE_BG, path); | ||
| twin_paint_stroke(window->pixmap, TWIN_ACTIVE_BORDER, path, bw_2 * 2); |
There was a problem hiding this comment.
The reason that the title bars don't show is because you need to determine the trajectory you want to paint first and then use twin_paint_path or twin_paint_stroke to fill the graph or draw the border.
I think the twin_window_active_paint would be like
static void twin_window_active_paint(twin_window_t *window)
{
// Ignore the above
twin_path_t *path = twin_path_create();
twin_path_move(path, c_left, c_top);
twin_path_draw(path, c_right, c_top);
twin_path_curve(path, c_right, w_top + t_arc_1, c_right - t_arc_1, w_top,
c_right - t_h, w_top);
twin_path_draw(path, c_left + t_h, w_top);
twin_path_curve(path, c_left + t_arc_1, w_top, c_left, w_top + t_arc_1,
c_left, c_top);
twin_path_close(path);
if (window->active) {
twin_paint_path(window->pixmap, TWIN_ACTIVE_BG, path);
twin_paint_stroke(window->pixmap, TWIN_ACTIVE_BORDER, path, bw_2 * 2);
} else {
twin_paint_path(window->pixmap, TWIN_INACTIVE_BG, path);
twin_paint_stroke(window->pixmap, TWIN_INACTIVE_BORDER, path, bw_2 * 2);
}
}There was a problem hiding this comment.
Thank you! It seems that using the "twin_window_frame()" function directly is still the better option. Originally, I thought this just changed the BG and border colors. But since there is no path record, it is not sure where to apply the colors.
There was a problem hiding this comment.
How about adding a twin_path_t *label_path member to twin_window_t? In twin_window_frame, you could initialize the path, and in twin_window_active_paint, determine the color to paint when the top window changes. Then you can still apply the colors in the same logic.
static void twin_window_active_paint(twin_window_t *window)
{
twin_fixed_t bw = twin_int_to_fixed(TWIN_TITLE_BW);
twin_path_t *path = twin_path_create();
twin_fixed_t bw_2 = bw / 2;
if (window->active) {
twin_paint_path(window->pixmap, TWIN_ACTIVE_BG, window->label_path);
twin_paint_stroke(window->pixmap, TWIN_ACTIVE_BORDER, window->label_path, bw_2 * 2);
} else {
twin_paint_path(window->pixmap, TWIN_INACTIVE_BG, window->label_path);
twin_paint_stroke(window->pixmap, TWIN_INACTIVE_BORDER, window->label_path, bw_2 * 2);
}
}
static void twin_window_frame(twin_window_t *window)
{
/* Ignore the above */
window->label_path = twin_path_create();
twin_path_move(window->label_path, c_left, c_top);
twin_path_draw(window->label_path, c_right, c_top);
twin_path_curve(window->label_path, c_right, w_top + t_arc_1, c_right - t_arc_1, w_top,
c_right - t_h, w_top);
twin_path_draw(window->label_path, c_left + t_h, w_top);
twin_path_curve(window->label_path, c_left + t_arc_1, w_top, c_left, w_top + t_arc_1,
c_left, c_top);
twin_path_close(window->label_path);
twin_window_active_paint(window);
}There was a problem hiding this comment.
OK, Thank you! we can try which one can work on framebuffer.
When the box is trigger by TwinEventButtonDown, its window's title bar needs to change color and be put onto the toppest layer. However, after removing the implementation of changing the color of window's title bar from the function twin_screen_update(), it will only be putted onto the toppest layer. Therefore, add the twin_window_frame() to update the color when box is triggered by TwinEventButtonDown.
|
Here's the output from 512a891 on the Pi 3B. drm.mp4 |
| @@ -1173,6 +1173,8 @@ void twin_window_damage(twin_window_t *window, | |||
| twin_coord_t right, | |||
| twin_coord_t bottom); | |||
|
|
|||
| void twin_window_frame(twin_window_t *window); | |||
| @@ -157,7 +157,7 @@ void twin_window_set_name(twin_window_t *window, const char *name) | |||
| twin_window_draw(window); | |||
| } | |||
|
|
|||
| static void twin_window_frame(twin_window_t *window) | |||
| void twin_window_frame(twin_window_t *window) | |||
There was a problem hiding this comment.
Why did you change this function from static to non-static?
Remove the inefficiently function twin_active_pixmap(). This function finds the currently and previously active window pixel map by traversing the list of pixel maps. This function will be called every time the screen needs to be updated. Set the active variable of the window only when the window's event TwinEventButtonDown is triggered to avoid redundant operations. Additionally, implement the function twin_window_active_paint() to only repaint the title bar instead of calling the function twin_window_draw() to indirectly call the function twin_window_frame to repaint the title bar of the window.
Close #92